Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Bar with Custom View not appearing from the bottom #10

Closed
jobernas opened this issue Feb 19, 2019 · 3 comments
Closed

Cookie Bar with Custom View not appearing from the bottom #10

jobernas opened this issue Feb 19, 2019 · 3 comments
Labels

Comments

@jobernas
Copy link

When I set the Cookie Position to Bottom with a Custom View, the animation comes from the bottom but it only stops at the top. It does not stop to the bottom of the window.

@jobernas
Copy link
Author

jobernas commented Feb 19, 2019

I compared the layout of my custom view it the default from the library and the main diference was the property android:layout_gravity="bottom" on the android:id="@+id/cookie" container.
I added this to my Custom layout and it worked. Now it sticks at the bottom.

I don't know if you wanna leave this information for other developers that have this issue. Would be cool if the lib add this property by us if the position is Bottom.

By the way, thanks for this cool lib.

@AviranAbady
Copy link
Owner

Thanks @jobernas, will be fixed in the next version.

AviranAbady added a commit that referenced this issue Apr 5, 2019
@AviranAbady
Copy link
Owner

Closing issue, fix included in release 1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants