Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tile mode used in SkShader for a TileBrush with None TileMode #16021

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Jun 13, 2024

What does the pull request do?

Changes the SKShaderTileMode used for TileBrushes with None Tile from Clamp to Decal. This removes the clamping effect on tile brushes that do not fill the control's bounds, and makes tile brushes behave closer to Wpf's in that regard.

What is the current behavior?

When TileBrush is used with TileMode None and destination rect doesn't fill the control's bounds, the clamping effect causes smearing along the axes.
image

What is the updated/expected behavior with this PR?

Using Decal skia tile mode instead of Clamps, the smear is gone;
image

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049006-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@emmauss emmauss added this pull request to the merge queue Jun 13, 2024
Merged via the queue into master with commit e8c3bf5 Jun 13, 2024
11 of 12 checks passed
@emmauss emmauss deleted the tile_brush_tilemode_none_fix branch June 13, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants