Handle case when TaskBarList could not be created #15852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
Sorien
reviewed
May 29, 2024
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
grokys
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Handle case when TaskBarList could not be created * Use HRESULT.S_OK for better clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Checks whether TaskBarList successfully created.
What is the current behavior?
Current code assumes TaskBarList is supported on all windows version. On Windows Server Core editions TaskBarList is not supported (no taskbar) and creating a window crashes the application.
What is the updated/expected behavior with this PR?
Applications could start on Windows Server Core. Tested on Windows Server 2016 Core.
Checklist
Fixed issues
Fixes #15840