SkiaSharp updates, SkiaSharp 3.0 render tests enabled #15255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason some tests are failing with |
|
What would happen if Skia and Skia3 render tests are running in parallel (e. g. from an IDE runner)? |
|
@kekekeks removed Skia3 unit test project. But kept a msbuild property, so one could run tests with it manually. |
maxkatz6
added a commit
that referenced
this pull request
Apr 20, 2024
* Use 2.88.8-preview.1.1 skiasharp * Use SKImageFilter directly, as we don't need compat anymore * Add SkiaSharp 3 render tests * Enable SkiaSharp 3 tests on CI * Add IncludeLinuxSkia in Skia tests * Update Skia version, remove SkiaCompat * Remove Skia3 test project, reuse single Skia render test project, so they won't conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?