Fix popups in Windows being offset incorrectly by a workaround for another issue #12725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
jmacato
approved these changes
Aug 30, 2023
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Fix popups in Windows being offset incorrectly by a workaround for another issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes a bug that was introduced by a workaround for another
Windowissue in Windows. The bug causes popups to be offset incorrectly from their intended location by a pixel.What is the current behavior?
Popups are often offset incorrectly by a pixel in Windows.
What is the updated/expected behavior with this PR?
The incorrect offset is fixed.
How was the solution implemented (if it's not obvious)?
Updated code to not apply the Windows
HiddenBorderSizeworkaround when the window is for a popup.Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #12587