Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Remove survey banner #92579

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Assembler: Remove survey banner #92579

merged 1 commit into from
Jul 11, 2024

Conversation

taipeicoder
Copy link
Contributor

Proposed Changes

This PR removes the survey banner as discussed in p1720620934370169-slack-C048CUFRGFQ.

Before After
Screenshot 2024-07-11 at 1 31 55 PM Screenshot 2024-07-11 at 1 32 14 PM

Why are these changes being made?

No need to gather user feedback at the moment.

Testing Instructions

  • Head to the Assembler.
  • Continue the Assembler until you reach the confirmation screen.
  • Ensure that the survey is no longer available.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@taipeicoder taipeicoder self-assigned this Jul 11, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/assembler-survey on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder requested a review from a team July 11, 2024 05:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 11, 2024
@taipeicoder taipeicoder merged commit a16d731 into trunk Jul 11, 2024
14 checks passed
@taipeicoder taipeicoder deleted the remove/assembler-survey branch July 11, 2024 05:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 11, 2024
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants