Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fail build on tsc errors #58899

Merged
merged 1 commit into from
Dec 8, 2021
Merged

ci: Fail build on tsc errors #58899

merged 1 commit into from
Dec 8, 2021

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Dec 7, 2021

Changes proposed in this Pull Request

Fail Unit test if the number of TypeScript errors (aka Code Inspection errors) increases respect the last successful build

Config generated using TeamCity UI.

@scinos scinos requested a review from a team December 7, 2021 09:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

@scinos scinos changed the title Analytics: Migrate TrackComponentView away from UNSAFE_ methods (#58860) ci: Fail build on tsc errors Dec 7, 2021
@scinos scinos self-assigned this Dec 7, 2021
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@scinos scinos merged commit a9d3d42 into trunk Dec 8, 2021
@scinos scinos deleted the build/fail-build-tsc-errors branch December 8, 2021 04:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants