Olympique: add theme #8007
Olympique: add theme #8007
Conversation
|
General visual observations I love this one. It's so lovely.
The stripe up here is intentionally taller, that works better with the world map logo:
But looking at the demo site, I wonder if the navigation on the right should be top aligned? 
I like the style variations of this one a lot. Even if it doesn't go wild with typography: there's something so very olympic about the base helvetica-esque font, that it seems right for this one to not go wild there. I like these two:
The latter, light gray version, thanks for including a monochrome one. The contrast is a bit low though, I wonder if the text color could be a tad darker and still feel "light"? Templates overall look good:
Mobile looks fantastic. Except for the navigation overlay, it's lacking padding:
I believe there was a trick to adjust that padding? On the demo site, and you don't need to fix this because it's not shipping with the theme, but I notice this image is low resolution/blurry:
The list style here, I wonder if the left padding of the list block should be adjusted to push the bullets inwards? Or is it intentionally offset to the left?
For this quote in the About page, there's a curious little .. that I don't know where is coming from:
Probably also in the demo site category, but good to look at. Summary This is a really nice one. Beautiful, clean, olympic. It's virtually ready. There were a couple of small tweaks worth evaluating, a consideration for contrast on one of the style variations, but otherwise, this is ready to go! Nice one. |
We've just merged a PR that will hopefully fix them 🤞 #8011 |
Preview changesI've detected changes to the following themes in this PR: Olympique. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
@jasmussen, thanks again. All your feedback was considered on this new commit. The only exception is the quote block that apparently carries a I also decided to use photos on the demo site instead of pictograms. This way, the image duotones are more apparent and appealing. Please review it again asap. I am planning to have it submitted today. |
|
Theme looks good. The only piece is the inner padding of the navigation menu. Based on the code, it looks like we can't easily fix that without applying a root padding, which is not fitting for this theme. So one thing we can do is just remove the navigation at the bottom (it's fine, there's a menu at the top after all). OR, default it to not be a burger menu. This will, longer term stop being a problem as it should become possible to style the overlay separately. If you can either remove that navigation, or just default it to not be the hamburger, you can merge and ship this theme. Nice work! |
|
Ok, I'll remove that hamburger one, @jasmussen. In addition to what you said about Typography, I'll try to find options similar to Helvetica until the end of this week. This way, we'll have different (but coherent) options in our Style variations. Once we launch this, it's much easier to update. |
|
The font is fine as is! Doesn't have to be helvetica. In fact, the overused grotesk feels very olympic. No change needed from my end, pure appreciation. |
|
@jasmussen theme and demo site updated. |
|
Nice! Ship it! |
The integration was set up by @vcanales so let me CC him. |
A theme to celebrate the history of the international games and the milestones that have shaped their legacy.
Demo site