Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo: Fixing details and adding variations #7995

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

  • Fixing link issues generated by Save Changes to the Theme with the CBT plugin.
  • Organizing the new color palettes that will become new style variations in the next update.

@henriqueiamarino
Copy link
Collaborator Author

henriqueiamarino commented Aug 6, 2024

@jasmussen, please check this update when you have the time. As you suggested, it adds style variations to the merged Expo (Hall).

@jasmussen
Copy link
Member

Nice one. I'm curious why a Playground link didn't show up for this one. @mikachan no rush, do you know why?

Changes look good though, and work for me as I tested locally:

test

Codewise, it also looks like the translated text and the links work as intended:
Screenshot 2024-08-06 at 14 49 04

So this seems good to go from my end!

@mikachan
Copy link
Member

mikachan commented Aug 6, 2024

I'm curious why a Playground link didn't show up for this one.

That is strange, it even looks like the preview action ran successfully: https://github.com/Automattic/themes/actions/runs/10266636356/job/28405400264?pr=7995. We recently updated the workflow, @vcanales do you think it's related to that PR?

@henriqueiamarino henriqueiamarino merged commit 61d60a2 into trunk Aug 8, 2024
1 check passed
@henriqueiamarino henriqueiamarino deleted the update/expo-variations branch August 8, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants