Skip to content

Commit

Permalink
Add source files for support_url and copyright metadata
Browse files Browse the repository at this point in the history 
This was a result of Fastlane warning us about those metadata missing:

```
[13:20:30]: 😵  Failed: Incorrect, or missing copyright date-> using a copyright date that is any different from this current year, or missing a date
[13:20:32]: 😵  Failed: No broken urls-> unreachable URLs in app metadata
+------------------------+----------------+
|           Potential problems            |
+------------------------+----------------+
| Field                  | Failure reason |
+------------------------+----------------+
| copyright              | missing: 2023  |
| support URL: (fr-FR)   | empty url      |
| support URL: (sv)      | empty url      |
| support URL: (ja)      | empty url      |
| support URL: (nl-NL)   | empty url      |
| support URL: (ru)      | empty url      |
| support URL: (de-DE)   | empty url      |
| support URL: (id)      | empty url      |
| support URL: (tr)      | empty url      |
| support URL: (zh-Hans) | empty url      |
| support URL: (es-ES)   | empty url      |
| support URL: (it)      | empty url      |
| support URL: (ko)      | empty url      |
| support URL: (zh-Hant) | empty url      |
| support URL: (pt-BR)   | empty url      |
+------------------------+----------------+
[13:20:32]: precheck 👮‍♀️ 👮  found one or more potential metadata problems, but this won't prevent fastlane from completing 👍
```
  • Loading branch information
@mokagio
mokagio committed Aug 10, 2023
1 parent 776b64e commit 05f34c1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions fastlane/metadata/copyright.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2023 Automattic Inc.
1 change: 1 addition & 0 deletions fastlane/metadata/default/support_url.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://simplenote.com/contact

1 comment on commit 05f34c1

@mokagio
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result after these changes

image

👍

However:

  1. Simplenote macOS is not localized in ASC, so these checks are useless. There was a note about it in the release checklist saying to paste the notes manually in "What's new" and I was like "let's see what happens if I run the automation..."
  2. Running the automation resulted in an iOS version being created in the ASC listing, which was surprising. Further investigation is required.

Please sign in to comment.