Fix issue when system bar didn't disappear on full screen video player #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… screen video player"
mchowning
approved these changes
Oct 23, 2022
There was a problem hiding this comment.
Thanks so much for this contribution! This works great!
For reference, in testing this I was able to recreate the issue somewhat consistently if I used the 2-button navigation (I couldn't recreate the issue with gesture navigation turned on) and I rotated the device a few times while a video was playing and the navigation bar was visible—eventually it would get stuck.
With this fix though, I wasn't able to recreate the issue anymore. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
System bar wasn't disapearing on full screen after when user tapped on screen
Fixes #115
Checklist