Do not replace timeskip when it is in a URL #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug occurs in the show notes when a URL contains a text formatted like a timeskip. In this scenario, the text should not be replaced, as it will break the URL.
Fixes #145
What is done
I wrote a method that checks whether a potential timeskip is in a URL by finding the nearest HTML closing tag to the potential timeskip.
I have also written a new test that checks the exact string the issue occurred on.
Checklist
Are all the strings localized?I havent touched any string resourcesDid you include Compose previews with any components?I havent used composeVideo:
timeskipinurlfix.mp4