Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets textZoom to 100 for webview #446

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Sets textZoom to 100 for webview #446

merged 1 commit into from
Oct 21, 2022

Conversation

josepatinob
Copy link
Contributor

@josepatinob josepatinob commented Oct 21, 2022 •
edited
Loading

Description

The webview in the Help & Feedback section was affected by the user's display size settings, which was causing the buttons in the Get in touch modal to overlap. Setting the textZoom to 100 will alleviate the problem on that particular webview.

Fixes # (Help & Feedback: Get in touch: Buttons overlap out of the container #114)

Checklist

  • Should this change be included in the release notes? If yes, please add a line in CHANGELOG.md
  • Have you tested in landscape?
  • Have you tested accessibility with TalkBack?
  • Have you tested in different themes?
  • Does the change work with a large display font?
  • Are all the strings localized?
  • Could you have written any new tests?
  • Did you include Compose previews with any components?

Screenshot (Oct 21, 2022 3 41 18 PM)

@josepatinob josepatinob requested a review from a team as a code owner October 21, 2022 19:39
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

geekygecko
geekygecko approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I didn't know that setting existed.

@geekygecko geekygecko merged commit 3791a48 into Automattic:main Oct 21, 2022
@josepatinob josepatinob deleted the fix/get-in-touch-buttons-overlap branch October 24, 2022 13:22
@ashiagr ashiagr added this to the 7.26 milestone Oct 31, 2022
@mchowning mchowning mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekygecko geekygecko geekygecko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josepatinob @CLAassistant @geekygecko @ashiagr