Taskerplugin #431
Taskerplugin #431
Conversation
…from the Tasker action since that will follow the order selected by the user in the app itself
|
|
…insert Tasker variables in inputs of both actions
There was a problem hiding this comment.
Thanks so much for this contribution! It's very exciting to see Tasker integration for Pocket Casts! (side note—over 10 years ago, Tasker was the very first Android app that I paid for, and I still use it today 😄 )
I left a couple of comments, but I know that this is just a first iteration, so most of them don't need to be addressed in this PR if you'd rather not. The only change I think we should definitely do before merging this is removing the copied test classes.
When you're making that change, if you'd care to add an entry to the changelog for this, I'd appreciate it. Wording roughly along these lines could work:
7.26
-----
* New Features:
* Added Tasker integration with filter and chapter controls.
([#431](https://github.com/Automattic/pocket-casts-android/pull/431)).
...askerplugin/src/main/java/au/com/shiftyjelly/pocketcasts/taskerplugin/base/ComposableBase.kt
Outdated
Show resolved
Hide resolved
...askerplugin/src/main/java/au/com/shiftyjelly/pocketcasts/taskerplugin/base/ComposableBase.kt
Show resolved
Hide resolved
...askerplugin/src/main/java/au/com/shiftyjelly/pocketcasts/taskerplugin/base/ComposableBase.kt
Outdated
Show resolved
Hide resolved
...askerplugin/src/main/java/au/com/shiftyjelly/pocketcasts/taskerplugin/base/ComposableBase.kt
Outdated
Show resolved
Hide resolved
...est/java/au/com/shiftyjelly/pocketcasts/taskerplugin/viewmodel/ManualCleanupViewModelTest.kt
Outdated
Show resolved
Hide resolved
…ayback" Tasker action and cleaned up some code
- Added "Skip to Time" and "Play Next In Queue" commands to "Control Playback" Tasker action
- Updated Changelog
- In the Tasker action configuration screen:
- Allowed only either the variable selection or the item selection dropdown to show at a time
- Don't show duplicate Tasker variables and sort them alphabetically
- Allow user to dismiss dropdown menus by clicking away from them
- Changed keyboard IME action to "Done"
- Changed Variable Select icon to be the same as in Tasker itself
- Made dropdown size limited so it shows correctly in all circumstances
- Added auxiliary "OptionalField" class in the "ViewModelConfigControlPlayback" class so that optional input fields that depend on the type of command being used can very easily be added with minimal code
|
Hi Matt! Thank you very much for the review! Really appreciate all the attention to detail. 🙂 And, you know what, Tasker was also the first app I bought all those years ago as well, back when I was not Tasker's developer! It's awesome to be able to work on it myself now and it has the added advantage of easily being able to add stuff to it that I need myself like now, with this Pocket Casts addition! I've been using Pocket Casts for a very long time and I'm very much looking forward to being able to play a filter with a physical button in my car, without even having to turn on my phone's screen! 😁 I've gone ahead and fixed all the issues you mentioned and also added a couple new commands to the Control Playback action in Tasker: Play Next In Queue and Skip To Time. Hope that's ok! Let me know if there's anything else I can do. I really can't wait for this to be available for everyone! Thank you! |
There was a problem hiding this comment.
Thanks for the updates. I'd like us to keep iterating on the UI, so I logged an issue for that here. I also tested the new actions and they all worked great, so I'll go ahead and merge this. Thanks so much for the contribution!
|
Awesome! :) Glad to hear it! Thanks again! |
Description
Adds a Tasker plugin so that users can interact with Pocket Casts from Tasker directly, without the need to use user-unfriendly intents.
For now it's kind of just a proof of concept with an action to automatically start playing any playlist (filter) by name.
It's super easy to add new actions now though, so that users can interact with Pocket Casts from Tasker in any way they choose. :)
I'm going to personally use this so I can have a button that I can press which will automatically start playing my favorite playlist without having to go into Pocket Casts' UI.
Let me know if there are any issues :) Thanks!
Checklist