End of Year: Add stories structure #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to pass custom values for border, colors, iconImage
ashiagr
commented
Oct 20, 2022
Comment on lines
+22
to
+28
| fun SegmentedProgressIndicator( | ||
| @FloatRange(from = 0.0, to = 1.0) progress: Float, | ||
| modifier: Modifier = Modifier, | ||
| color: Color = Color.White, | ||
| backgroundColor: Color = color.copy(alpha = IndicatorBackgroundOpacity), | ||
| numberOfSegments: Int, | ||
| ) { |
There was a problem hiding this comment.
Most of the logic is taken from Compose internal implementation of LinearProgressIndicator and this answer.
It doesn't support RTL animation right now.
mchowning
approved these changes
Oct 20, 2022
...features/endofyear/src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/StoriesFragment.kt
Show resolved
Hide resolved
...s/features/endofyear/src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/StoriesScreen.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the initial stories screen. No functionality is built on this PR, just the view.
iOS PR: Automattic/pocket-casts-ios#383
stories_view.mp4
To test
END_OF_YEAR_ENABLEDfeature flag totrueinbase.gradleChecklist