Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Halloween icon #415

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Added a Halloween icon #415

merged 6 commits into from
Oct 19, 2022

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented Oct 19, 2022

This change adds a new app Halloween icon.

Another change I made was to resize the images for the Red Velvet and Radioactivity in the settings appearance page. The code has a max width for the images of 124dp in the recycler view adapter. This change reduced the apk size from 23.9MB to 22.8MB.

Test steps

  1. Make you use have Plus
  2. Tap the Profile tab
  3. Tap the Setting cog
  4. Tap Apperance
  5. Swipe the "App Icon" list to see the Halloween icon at the end of the list
  6. Tap the Halloween icon
  7. Quit the app
  8. Swipe up into the list of apps
  9. ✅ Verify the Halloween app icon is visible

Screenshots

@geekygecko geekygecko marked this pull request as ready for review October 19, 2022 03:30
@geekygecko geekygecko requested a review from a team as a code owner October 19, 2022 03:30
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I might want to cherry-pick into 7.24_ release if we decide to increment version code for 7.24 and upload another release for it.

@ashiagr ashiagr merged commit 21cf92b into main Oct 19, 2022
@ashiagr ashiagr deleted the update/halloween-icon branch October 19, 2022 06:14
ashiagr added a commit that referenced this pull request Oct 21, 2022
ashiagr added a commit that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants