Added in the ability to disable automatic validation when a model is sav... #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed an extraneous comment
vkarpov15
added a commit
that referenced
this pull request
May 16, 2014
Added in the ability to disable automatic validation when a model is sav...
|
Heya, since this is a new feature, its going to go into v3.9 instead of 3.8.x. Sorry, minor mistake on my part. |
vkarpov15
added a commit
that referenced
this pull request
May 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We like the Mongoose validation functionality. However, we have found a requirement that we need to be able to save a certain type of document even though it failed validation, because we store the validation errors in the database with that document, and a human later reviews said document.
I don't want to abandon Mongoose validation entirely just because of this requirement though. So we made a change to allow users to disable the automatic validation when saving using an option on the schema (of course its enabled by default.).
Please merge, since otherwise we will be required to maintain our own version of mongoose.