Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entry Headline and clear when creating new entry #474

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adamsilverstein
Copy link

Extends #473 with clearing of the headline editor when creating a new entry.

Fixes #375

Based on paulschreiber#17

  • Add a headline field above the TinyMCE editor, (similar to LivePress).
  • Headline field is optional.
  • Store the headline in wp_comment meta.
  • Send the headline over JSON as part of the API request for updates.
  • Render the headline, if present, in EntryContainer.js
  • php rendering for headline in liveblog-single-entry.php
  • Clear headline after posting from main/top editor (track last update)
  • Sync headline from data when using inline editor/editing exiting entries

@adamsilverstein
Copy link
Author

Added the built files as well, @cain can you give this a test?

@cain
Copy link
Contributor

cain commented May 31, 2018

@adamsilverstein Done some basic testing, seems to be working fine.

Whats everyones thoughts on using the headline as the key event widget content? Seems like it would be perfect and fix issue #464

@philipjohn
Copy link
Contributor

Whats everyones thoughts on using the headline as the key event widget content? Seems like it would be perfect and fix issue #464

Yep, I think that'd be a good addition!

@paulschreiber paulschreiber deleted the pr-473 branch September 17, 2019 18:43
@GaryJones
Copy link
Contributor

This is going to need to be rebased to be testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add headline/title to each update
4 participants