Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release cleanup #2806

Merged
merged 17 commits into from
Jun 26, 2024
Merged

Pre-release cleanup #2806

merged 17 commits into from
Jun 26, 2024

Conversation

sgdc3
Copy link
Member

@sgdc3 sgdc3 commented Apr 26, 2024

This is a quick cleanup clean things up before the 5.6.0 release

@sgdc3
Update to spigot 1.20.5, bump mvn plugin version, require jvm 17, req…
1b69abd 
…uire mvn 3.9, require spigot 1.19, use the spigot runtime dependency download system, use the official maxmind geoip database parser
@sgdc3
Update usage of deprecated org.junit.Assert.assertThat
90be2af
@sgdc3
Delete unused samples
14af43d
@sgdc3
Merge branch 'master' into pre-release-cleanup
c880298 
# Conflicts:
#	pom.xml
#	src/test/java/fr/xephi/authme/service/GeoIpServiceTest.java
#	src/test/java/fr/xephi/authme/service/ValidationServiceTest.java
@sgdc3
Fix merge
3da21bc
@sgdc3
Dependabot: unlock Hikaricp
b1f565a
@sgdc3 sgdc3 requested review from games647, hex3l and ljacqu April 26, 2024 01:23
@ljacqu
Copy link
Member

ljacqu commented Apr 27, 2024 •
edited
Loading

AsynchronousUnregisterTest, GeoIpServiceTest -> failing because of Mockito. I'm on it ;)

Edit: done

ljacqu
ljacqu reviewed Apr 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
src/main/java/fr/xephi/authme/initialization/OnStartupTasks.java Show resolved Hide resolved
src/main/java/fr/xephi/authme/listener/protocollib/InventoryPacketAdapter.java Outdated Show resolved Hide resolved
src/main/java/fr/xephi/authme/listener/protocollib/InventoryPacketAdapter.java Outdated Show resolved Hide resolved
@ljacqu
Copy link
Member

ljacqu commented Apr 28, 2024

Changes look good to me.

  • Probably need to add the released datasourcecolumns to plugin.yml's libraries
  • The build from GitHub Actions is failing because it's using an incompatible Maven version

@sgdc3
Copy link
Member Author

sgdc3 commented Apr 28, 2024

@ljacqu tests on JDK 21 are failing, should we fix that or just skip JDK 21 in the pipeline?

@ljacqu
Copy link
Member

ljacqu commented Apr 28, 2024

tests on JDK 21 are failing, should we fix that or just skip JDK 21 in the pipeline?

Fixed (I think)

@sgdc3 sgdc3 changed the title [WIP] Pre-release cleanup Pre-release cleanup Apr 28, 2024
@HaHaWTH HaHaWTH mentioned this pull request Apr 29, 2024
Open
games647
games647 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@games647 games647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested.

!LGTM

"!LGTM" (Looks good to me) in pixel GitHub commit history where pixel represents a day of the year with a high commit count

@sgdc3 sgdc3 merged commit 8ebe461 into master Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@games647 games647 games647 approved these changes

@ljacqu ljacqu ljacqu approved these changes

@hex3l hex3l Awaiting requested review from hex3l

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgdc3 @ljacqu @games647