Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public #65

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Add public #65

merged 1 commit into from
Oct 9, 2022

Conversation

ipodishima
Copy link
Contributor

Exposing AudioHelpers

Also @aure : I replaced getFileEndTime by duration from AudioKit. Only difference is getFileEndTime uses processingFormat where duration uses fileFormat. Not sure if it has an impact...

@NickCulbertson
Copy link
Member

@aure
Copy link
Member

aure commented Oct 6, 2022

I'm just awaiting @Matt54 to chime in that this is okay by him.

@aure aure merged commit 22e8fb0 into AudioKit:main Oct 9, 2022
@Matt54
Copy link
Member

Matt54 commented Oct 9, 2022

Hey sorry for the delay - been a crazy busy week. Looks good though!

@Matt54
Copy link
Member

Matt54 commented Oct 9, 2022

@aure I've got these rms analysis methods duplicated in other projects since I didn't want the AudioKitUI dependency. Reminds of that idea of spitting off a package just for utility functions

@ipodishima ipodishima deleted the add-public branch October 10, 2022 09:04
@ipodishima
Copy link
Contributor Author

Yes, I wanted to go deeper into the changes but saw that some things belong to AudioKitUI, like the loadAudioSignal.
IMHO it could belong to AudioKit or like you said, a utility package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants