Search #96
Merged
Search #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a problem with search bar extending
improve search show/hide remove white background
sieren
reviewed
Jul 3, 2019
Podfile.lock
Outdated
| @@ -46,4 +46,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: 5a6fc3652ff27185dbe549b41dce70a850fa2ea3 | |||
|
|
|||
| COCOAPODS: 1.7.0 | |||
| COCOAPODS: 1.6.1 | |||
There was a problem hiding this comment.
This probably shouldnt be in this PR
There was a problem hiding this comment.
I now have cocoapods 1.7.0 installed, & pushed revised lockfile which has caused it to drop out of this PR
|
Looks good on first look, @marcussatellite are you gonna test this locally? |
@sieren My problem is that it doesn’t look good - the UISearchBar is extending where it shouldn’t. Need a bit of advice on that. Sent with GitHawk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch (& description) search functionality
NEEDS WORK - UISearchBar sizing