Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an alternative take on #124 with a little less code and reusing the
MIDIToggleButton
.Dev Changes
We're using a new class called MIDIRecordButton that inherits from MIDIToggleButton.
Instead of using PaintCode we add a Circle Subview and when
isOn
is true, we animatethe backgroundColor of said Circle View.
User Facing Changes
The UI is now more in line with the rest of Synth One. An active recording is indicated by both the time progressed as well as the animated button.
@marcussatellite @analogcode adding the SubView in
layoutSubviews
is probably not the right place, let me know if you know of a better function for this.