Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording button #125

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Conversation

sieren
Copy link
Contributor

@sieren sieren commented Nov 27, 2019

Here's an alternative take on #124 with a little less code and reusing the MIDIToggleButton.

Dev Changes
We're using a new class called MIDIRecordButton that inherits from MIDIToggleButton.
Instead of using PaintCode we add a Circle Subview and when isOn is true, we animate
the backgroundColor of said Circle View.

User Facing Changes
The UI is now more in line with the rest of Synth One. An active recording is indicated by both the time progressed as well as the animated button.

@marcussatellite @analogcode adding the SubView in layoutSubviews is probably not the right place, let me know if you know of a better function for this.

Screenshot 2019-11-27 at 19 21 41

Screenshot 2019-11-27 at 19 21 37

Screenshot 2019-11-27 at 19 26 20

Add a MIDIRecordButton with a Circe Image that
inherits from MIDIToggleButton with some custom additions.
Use the new MIDIRecordButton in our Storyboard.
@analogcode analogcode merged commit b519e20 into AudioKit:develop Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants