Replace ChimpKit SDK Dependency #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieren
force-pushed
the
replace-chimpkit
branch
4 times, most recently
from
728d4a2
to
17c0339
Compare
3 tasks
Add a service that handles the API Endpoints of MailChimp. Added functionality to subscribe new users and resubscribe existing users that signed up again but may have unsubscribed in the past.
Remove the ChimpKit SDK from this project.
sieren
force-pushed
the
replace-chimpkit
branch
from
17c0339
to
c2bc4df
Compare
This was referenced Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
this PR removed the dependency on the ChimpKit SDK.
Background: The ChimpKit SDK repo has not been updated in 5-6 years and is showing it's age. It does not compile when using Catalyst (Catalina) as a target and it is using the deprecated APIv2 of MailChimp.
This API is well documented and I've written a little class against it.
Changes: ChimpKit is removed from PodFile. A new class called
MailChimpis being put in place as a drop-in replacement with a similar API as before. Higher-level changes are therefore minimal.New: Previously users had no choice to resubscribe when they unsubscribed in the past. This PR adds functionality and checks that - if a user had subscribed in the past, we will send him/her an "opt-in" email. The reason is that we might want to prevent malicious actors from signing up third-parties. This means:
I have tested and verified these behaviours with multiple accounts of my own.
@aure @analogcode if we use ChimpKit in other AK Apps, this may be a universal suitable replacement.