Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 13 Crash Fixes #115

Merged
merged 5 commits into from
Oct 25, 2019
Merged

iOS 13 Crash Fixes #115

merged 5 commits into from
Oct 25, 2019

Conversation

sieren
Copy link
Contributor

@sieren sieren commented Oct 25, 2019

Hey,

Please read each commit in the history to see whats going on.

TL'DR:

  • Moved a lot of audio-engine functionality that was called from the View Code into the Conductor.
  • Instantiation of Engine and Conductor is now happening in AppDelegate so it's guaranteed to only be called once
  • AudioPlot is also a part of the Conductor now, better solutions are appreciated because it's technically UI Code (with an Engine dependency)
  • Reinstantiated the Constraints from @analogcode previous experiments
  • AudioBus MIDI Code is now part of the Conductor and the Manager is a delegate to incoming AB Midi messages.

Please test this if possible, especially the AudioBus related stuff.

@sieren
Move Conductor Start to AppDelegate
f057ae2 
We should not rely on ViewDidLoad to be called just once,
therefore calling "start" multiple times on AudioKit which
can lead to crashes.
@sieren
Move Sustainer to Conductor
9a1432b
@sieren
Move AudioBus to Conductor
3b9db91 
Move AudioBus and all its dependencies to the Conductor.
Register Manager as an optional delegate to handle
incoming MIDI through AudioBus (AKMIDIListener Protocol).

Move MIDIChannel and Omni configuration to Conductor.
@sieren
Reinstantiate Keyboard Constraints
8296836 
Reinstantiate Keyboard Constraints
@sieren
Move AudioPlot Setup to Conductor
7ef3ec3 
This was a tricky one. AudioPlot is technically UI Code but also
relies on attaching a node to the AudioKit Engine.
UI Code shouldn't live in the conductor, so consider this a bandaid fix.
@analogcode analogcode merged commit 3df0cb9 into AudioKit:develop Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aure aure Awaiting requested review from aure

@analogcode analogcode Awaiting requested review from analogcode

@marcussatellite marcussatellite Awaiting requested review from marcussatellite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sieren @analogcode