Fix FormatConverter+Compressed on iOS 18, macOS 15, tvOS 15 and VisionOS 2 #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to issue: #2921 |
1998code
changed the title
|
@aure / @wtholliday Please help review this PR. Thanks. |
|
Bump :) Thanks for doing this @1998code! I'm seeing this when compiling using Xcode 16 even for visionOS 1.1 and 1.2? |
|
Welcome @warpling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use export(to:as:) instead.
Remark:
The old one was fully deprecated on visionOS 2 and Xcode 16. Failed to fallback.
As a workaround, I used
#if !os(visionOS)...to prevent crashes.Ref Doc:
https://developer.apple.com/documentation/avfoundation/avassetexportsession/4354409-export