Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Update remark to version 5.0.1 🚀 #73

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

@greenkeeperio-bot greenkeeperio-bot commented Jun 12, 2016

Hello lovely humans,

remark just published its new version 5.0.1.

State Update 🚀
Dependency remark
New version 5.0.1
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of remark.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade


This change is Reviewable

@Arcanemagus
Copy link
Member

Well this is interesting, it seems to be failing because remark is complaining about needing to use remark-cli to lint the readme, when this package only uses remark.

@wooorm
Copy link
Contributor

wooorm commented Jun 13, 2016

Yup, I externalised the CLI! So now remark-cli should be installed (and in this module, both should, as both are used)

@Arcanemagus
Copy link
Member

It should only be a devDependency though, right? The package itself only uses remark if I'm not mistaken.

@wooorm
Copy link
Contributor

wooorm commented Jun 13, 2016

No, we’re using the lib/cli/configuration file.

Now I think of it, just updating won’t work either, I’ve changed quite a lot and have to see how to bring it all to linter-markdown :( I’ll try to get to it tonight / tomorrow?

@Arcanemagus
Copy link
Member

Looks like it doesn't like both being installed:
image

@Arcanemagus
Copy link
Member

Okay, I'll just leave it to you then, if you need any help let me know!

@wooorm
Copy link
Contributor

wooorm commented Jul 6, 2016

@Arcanemagus Sorry, it has taken me longer than expected, and it’s going to take me even more time 😧

@Arcanemagus
Copy link
Member

No worries, I'll get the eslint update right now, it's waiting on an update to the Atom CI script anyway.

wooorm added a commit that referenced this pull request Jul 27, 2016
*  Update remark to version 5.0.0;
*  Use `unified-engine-atom` to deal with processing,
   this adds support for `.remarkignore` files, local remark-lint
   configuration files.

Closes GH-71 -  `remark-lint` specified in `.remarkrc` or
`package.json` files now precedes over the packaged `remark-lint`.

Closes GH-73 - Update `remark`;

Closes GH-76, closes GH-83 - Using `unified-engine`, which comes with
pretty JSON errors.
wooorm added a commit that referenced this pull request Jul 27, 2016
*  Update remark to version 5.0.0;
*  Use `unified-engine-atom` to deal with processing,
   this adds support for `.remarkignore` files, local remark-lint
   configuration files.

Closes GH-71 -  `remark-lint` specified in `.remarkrc` or
`package.json` files now precedes over the packaged `remark-lint`.

Closes GH-73 - Update `remark`;

Closes GH-76, closes GH-83 - Using `unified-engine`, which comes with
pretty JSON errors.
@Arcanemagus
Copy link
Member

This PR is superseded by #93.

@Arcanemagus Arcanemagus closed this Aug 9, 2016
@Arcanemagus Arcanemagus deleted the greenkeeper-remark-5.0.1 branch August 9, 2016 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants