commit progress organisation metrics #3146 #982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisala
requested changes
Jun 25, 2024
| def organisation = Organisation.findByOrganisationId(id) | ||
|
|
||
| boolean approvedOnly = true | ||
| boolean targetsOnly = false |
There was a problem hiding this comment.
Organisations don't have a concept of targets so we should delete targetsOnly and includeTargets
| * | ||
| */ | ||
| def organisationMetrics(String id, targetsOnly = false, approvedOnly = false, List scoreIds = null, Map aggregationConfig = null, boolean includeTargets = true) { | ||
| def org = Organisation.findByOrganisationId(id) |
There was a problem hiding this comment.
Organisations don't have a concept of targets so we should delete targetsOnly and includeTargets
| List outputSummary = reportService.organisationSummary(id, toAggregate, approvedOnly, aggregationConfig) ?: [] | ||
|
|
||
| // Add project output target information where it exists. | ||
| if (includeTargets) { |
There was a problem hiding this comment.
Delete this section as organisations cannot have targets
|
@salomon-j this got moved to a different branch didn't it? It is safe to close this? |
yes it is safe to close it, I've created a new branch that was merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.