Handle multiple assertions by single user on single record correctly #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be an edge-case, but the existing primary key setup means that if a user raises more than one issue against a record, then only one verification of these can be saved: the rowkey, userId and code (50005 unconfirmed) would all be the same. Verifying another one of the user's issues against the same record overwrites the first one.
Including the relatedUuid field in the primary key fixes this, BUT it means non-verification qa entries must have an empty string ("") relatedUuid, instead of null, since part of a composite key cannot be null. This is fixed in the next pull request.
Allow single verification deletion, instead of all with particular code by particular user on single record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be an edge-case, but the existing primary key setup means that if a user raises more than one issue against a record, then only one verification of these can be saved: the rowkey, userId and code (50005 unconfirmed) would all be the same. Verifying another one of the user's issues against the same record overwrites the first one.
Including the relatedUuid field in the primary key fixes this, BUT it means non-verification qa entries must have an empty string ("") relatedUuid, instead of null, since part of a composite key cannot be null.