Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image service URL checks dont equate http and https URLs #364

Open
djtfmartin opened this issue Feb 27, 2020 · 0 comments
Open

Image service URL checks dont equate http and https URLs #364

djtfmartin opened this issue Feb 27, 2020 · 0 comments

Comments

@djtfmartin
Copy link
Member

Biocollect data references http urls (e.g. http:https://images.ala.org.au/image/proxyImageThumbnailLarge?imageId=3e1a5740-a4bd-465a-b034-c8b803790f3c) as oppose to https URLs.

This means the check to see if the URL is an image-service URL fails resulting in the image-service attempting to download the image from itself and then performing a duplicate test (MD5hash).

A minor enhancement to ignore the protocol will alleviate this, and hopefully improve loading performance.

djtfmartin added a commit that referenced this issue Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant