Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New image-service demands apikey for image uploading #337

Closed
andrevtg opened this issue Aug 7, 2019 · 5 comments
Closed

New image-service demands apikey for image uploading #337

andrevtg opened this issue Aug 7, 2019 · 5 comments
Assignees
Labels
bug IAD images Was "Image management"

Comments

@andrevtg
Copy link

andrevtg commented Aug 7, 2019

It seems to me that image-service (1.0.x) requires api keys in special http headers for certain endpoints (including image uploads at "/ws/uploadImage") and biocache does not provide it. I had no issues with that on 0.9.x, but I'm not sure if this is just a setting I missed.

I'll try to submit a PR for that.

@ansell
Copy link
Contributor

ansell commented Aug 7, 2019

I think that is part of this PR that I am currently reviewing: #336

andrevtg added a commit to andrevtg/biocache-store that referenced this issue Aug 7, 2019
@andrevtg
Copy link
Author

andrevtg commented Aug 7, 2019

Nice. I'll use my custom biocache until next release. Thanks for pointing this out.

@ansell ansell added bug IAD images Was "Image management" labels Sep 5, 2019
@ansell
Copy link
Contributor

ansell commented Sep 5, 2019

@andrevtg The pull request was merged and a new version of biocache-store has been released. Can you test it to verify it is working for you against your image-service (may need to bump to the image-service version that was also released in the last few hours)

@djtfmartin
Copy link
Member

@andrevtg note the API checks can be bypassed by whitelisting IP address

security:
  apikey:
    ip:
      whitelist: 123.123.123.123,124.124.124.124

@andrevtg
Copy link
Author

andrevtg commented Sep 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug IAD images Was "Image management"
Projects
None yet
Development

No branches or pull requests

3 participants