-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unusual System.exit call in BulkProcessor #125
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The main method in BulkProcessor contains a single path that calls System.exit instead of naturally completing. There is no reason to call System.exit(0) where it does, as there are no further instructions that would be run after that point and future maintainers may not realise this if they add any later code to the method:
https://github.com/AtlasOfLivingAustralia/biocache-store/blob/master/src/main/scala/au/org/ala/biocache/index/BulkProcessor.scala#L166
The text was updated successfully, but these errors were encountered: