Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alau_user_id field link broken for ALA users #318

Closed
peggynewman opened this issue Sep 30, 2019 · 7 comments
Closed

alau_user_id field link broken for ALA users #318

peggynewman opened this issue Sep 30, 2019 · 7 comments
Assignees
Milestone

Comments

@peggynewman
Copy link

Sample record:
https://biocache.ala.org.au/occurrences/04eacba3-cec1-4d6b-8822-78444655081d

The User ID field contains: David Sando
And links to: https://sightings.ala.org.au/spotter/David%20Sando

... but this errors. The link needs to be: https://sightings.ala.org.au/spotter/1267

If a change goes through it should also regression test the field for iNaturalist users.

Example record:
https://biocache.ala.org.au/occurrences/94f19c5b-1065-4ac1-9b77-2abf4c2bcbc4

The User ID field contains: peggydnew
And links to: https://inaturalist.ala.org.au/people/peggydnew

@ansell
Copy link
Contributor

ansell commented Sep 30, 2019

1267 is there as a raw value on the record, so this may just be a UI issue:

https://biocache-ws.ala.org.au/ws/occurrences/04eacba3-cec1-4d6b-8822-78444655081d

nickdos added a commit that referenced this issue Sep 30, 2019
BioCollect links had wrong ID in URL.
@nickdos nickdos self-assigned this Sep 30, 2019
nickdos added a commit that referenced this issue Oct 2, 2019
@nickdos
Copy link
Contributor

nickdos commented Oct 2, 2019

Deployed to biocache-test.

@peggynewman
Copy link
Author

Lovely. Works a treat for both record links above in biocache-test.

@ansell
Copy link
Contributor

ansell commented Nov 3, 2019

This is broken in the 3.2.3-SNAPSHOT that was just deployed to the current biocache-test system (it was newly deployed last week).

@ansell
Copy link
Contributor

ansell commented Nov 3, 2019

So I did the QA test for a sightings record on production where it is still broken. Fixed on test:

https://biocache-test.ala.org.au/occurrences/04eacba3-cec1-4d6b-8822-78444655081d

@ansell ansell closed this as completed Nov 3, 2019
@nickdos
Copy link
Contributor

nickdos commented Nov 11, 2021

This has broken with Pipelines changes.

  • BioCollect records now have alaUserId field but code is likely expecting ala_user_id or alau_user_id. Fix to use camelcase version
  • iNaturalist records are missing the expected user_id field in the JSON data. Dependent on Investigate why iNaturalist usernames are not coming across data-management#775. When data issue is fixed, check the field it marked-up as link, as per this issue details above.

@nickdos nickdos reopened this Nov 11, 2021
@adam-collins
Copy link
Contributor

It expects raw.occurrence.userId and alaUserName. I make the assumption that alaUserName is now raw.occurrence.recordedBy. This appears to resolve the issue for iNat and biocollect user links.

It does not resolve this issue for flickr links as they no longer have raw.occurrence.userId.

@adam-collins adam-collins assigned adam-collins and unassigned nickdos Jan 29, 2024
adam-collins pushed a commit that referenced this issue Jan 29, 2024
@adam-collins adam-collins added this to the 7.0.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants