Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection manager can't see "verify annotation" button #209

Closed
nickdos opened this issue Nov 4, 2016 · 6 comments
Closed

Collection manager can't see "verify annotation" button #209

nickdos opened this issue Nov 4, 2016 · 6 comments
Assignees
Labels

Comments

@nickdos
Copy link
Contributor

nickdos commented Nov 4, 2016

Margaret is listed as the collection manager for ANWC records but she can't see the "verify annotation" button. I can see it with ROLE_ADMIN access.

Edit: tracked it down to issue with Collectory with the contacts.json service failing.

@nickdos
Copy link
Contributor Author

nickdos commented Nov 9, 2016

Discovered collectory had an email address with uppercase letters but user's account contained all lowercase letters. Waiting to see if this fixed the issue.

nickdos added a commit that referenced this issue Nov 9, 2016
Case differences in email addresses between collectory and userdetails.
@nickdos
Copy link
Contributor Author

nickdos commented Nov 16, 2018

Needs testing - ask MC to try again...

@nickdos
Copy link
Contributor Author

nickdos commented Dec 5, 2021

Broken again - MC and US can't see verify button but ROLE_ADMIN users can see it. A simpler solution could be to use ROLE_COLLECTION_ADMIN in a smilar way to ROLE_ADMIN check is done, as the collectory collection/dataresource permission checking seems brittle and overly complicated for the <5 users who actually use this feature.

@nickdos nickdos self-assigned this Dec 5, 2021
@nickdos nickdos added the bug label Dec 5, 2021
nickdos added a commit that referenced this issue Dec 6, 2021
nickdos added a commit that referenced this issue Dec 6, 2021
Workaround until Collectory contacts.json bug is fixed
djtfmartin pushed a commit that referenced this issue Dec 9, 2021
Workaround until Collectory contacts.json bug is fixed
djtfmartin pushed a commit that referenced this issue Dec 9, 2021
Workaround until Collectory contacts.json bug is fixed
@nickdos
Copy link
Contributor Author

nickdos commented Jan 13, 2022

To test this, use an account that is NOT ROLE_ADMIN but has ROLE_COLLECTION_ADMIN. Check an existing annotation (not created by the current user) and look for the "Verify" button. Click through and try setting different verification status values - results should be fairly self obvious.

@Rita-C
Copy link
Contributor

Rita-C commented Jan 18, 2022

"flag an issue" threw error on biocache-test, log shows 403 returned from [biocache-service](https://biocache-ws-test.ala.org.au/ws), will check with @brucehyslop .
Tested on local, seems ok.

@nickdos
Copy link
Contributor Author

nickdos commented Feb 4, 2022

Seeing as bioche-test is currently in flux due to API gateway testing (and fact Dave has deprecated a bunch of services for it), I'm satisfied with the local testing for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants