Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#252 fix(add qualityProfile=ALA) #254

Merged
merged 5 commits into from
Jul 26, 2021
Merged

#252 fix(add qualityProfile=ALA) #254

merged 5 commits into from
Jul 26, 2021

Conversation

qifeng-bai
Copy link
Contributor

No description provided.

@qifeng-bai qifeng-bai requested a review from nickdos July 21, 2021 06:49
@nickdos nickdos self-requested a review July 26, 2021 03:00
Copy link
Contributor

@nickdos nickdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment

@@ -624,7 +626,7 @@ function loadGalleryType(category, start) {
var url = SHOW_CONF.biocacheServiceUrl +
'/occurrences/search.json?q=lsid:' +
SHOW_CONF.guid +
'&fq=multimedia:"Image"&pageSize=' + pageSize +
'&qualityProfile=ALA&fq=multimedia:"Image"&pageSize=' + pageSize +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be wrapped in a check for SHOW_CONF.qualityProfile so Living Atlas users don't see that param in their web service calls.

@nickdos nickdos self-requested a review July 26, 2021 03:33
@nickdos nickdos merged commit b7a5df5 into develop Jul 26, 2021
@nickdos nickdos deleted the qualityprofile branch July 26, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants