Search all images in occurrence for preferred image #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search across all images in a record, rather than just the first image. Include https: in default service URLs Include default imageServiceBaseUrl and match case across plugins
Rita-C
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Looks good to me, @charvolant .
I suppose you're going to update ansible templete for imageServiceBaseUrl?
Rita-C
reviewed
Oct 8, 2021
| @@ -502,10 +502,10 @@ function loadOverviewImages(){ | |||
| if (SHOW_CONF.preferredImageId) { | |||
| hasPreferredImage = true; | |||
| var prefUrl = SHOW_CONF.biocacheServiceUrl + | |||
| '/occurrences/search.json?q=image_url:' + SHOW_CONF.preferredImageId + | |||
| '/occurrences/search.json?q=images:' + SHOW_CONF.preferredImageId + | |||
There was a problem hiding this comment.
That's not a ideal change from biocache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #250