Feature/OIDC integration2 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 22, 2022 00:34
…ng root path to opeanpi swagger ui, removing redundant default index.gsp
…ng back previously removed dependenies
|
Required ansible configs have been added under feature branches. (To merge after this app is ready to deploy with OIDC) |
gradle.properties
Outdated
| grailsWrapperVersion=1.0.0 | ||
| gormVersion=6.0.12.RELEASE | ||
| gradleWrapperVersion=3.4.1 | ||
| grailsVersion=4.0.13 |
There was a problem hiding this comment.
Please upgrade to 4.1.1 or to any secured version
More info: https://grails.org/blog/2022-07-18-rce-vulnerability.html
| @@ -58,7 +58,7 @@ class UrlMappings { | |||
|
|
|||
| "/logout/logout" (controller: 'misc', action: 'logout') | |||
|
|
|||
| "/"(view: "/index") | |||
| "/"(redirect: "/openapi") | |||
There was a problem hiding this comment.
This tires to maintain the behaviour of the current bie-index's index / page which displays the swagger UI under the /index path. New changes replace the old swagger iplementation with openapi-1.0 for api spec definition and this change displayes the /opeanapi page for the / since old index page no longer exists.
yasima-csiro
requested changes
Jul 26, 2022
build.gradle
Outdated
| @@ -102,6 +102,8 @@ dependencies { | |||
| testCompile "org.seleniumhq.selenium:selenium-support:3.14.0" | |||
| testRuntime "org.seleniumhq.selenium:selenium-chrome-driver:3.14.0" | |||
| testRuntime "org.seleniumhq.selenium:selenium-firefox-driver:3.14.0" | |||
| // https://mavenlibs.com/maven/dependency/org.springframework/spring-messaging | |||
There was a problem hiding this comment.
Shall we remove this if it is necessary?
sughics
force-pushed
the
feature/oidcIntegration2
branch
from
20d79f5
to
91d4405
Compare
yasima-csiro
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grails4 upgrade and and OIDC in Integration