Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common names on species pages are not showing preferred name #373

Open
kylie-m opened this issue Aug 9, 2023 · 11 comments
Open

Common names on species pages are not showing preferred name #373

kylie-m opened this issue Aug 9, 2023 · 11 comments
Assignees
Milestone

Comments

@kylie-m
Copy link

kylie-m commented Aug 9, 2023

Common names on species pages are not showing preferred names.

For example, the Princess Parrot is now Alexandra's Parrot. https://bie.ala.org.au/species/https://biodiversity.org.au/afd/taxa/be7a08f5-387f-4156-91e2-77f0d3d09d8c

This isn't the preferred name for the species in AFD or the BirdLife list.

  • reported by Cam
@kylie-m kylie-m changed the title common names on species pages are not showing preferred name Common names on species pages are not showing preferred name Aug 9, 2023
@adam-collins
Copy link
Contributor

These will be fixed in the new names index with the addition of a field in the name-matching-service's index.

@TaniaGLaity
Copy link

will be fixed in the new backbone - suspect this is a duplicate of other issues

@adam-collins
Copy link
Contributor

A duplicate issue of AtlasOfLivingAustralia/ala-bie-hub#3

@TaniaGLaity
Copy link

related but not a duplicate?

@adam-collins
Copy link
Contributor

I assume that most recent comment is asking if it this issue is related to the linked issue only by the keyword common name.

This is not the case. Both are identical because the current vernacularname.txt does not indicate the preferred common name.

The new index fixes this issue because vernacularname.txt has the field <field index="13" term="http:https://rs.gbif.org/terms/1.0/isPreferredName"/>, see the work in progress index https://archives.ala.org.au/archives/nameindexes/20230725-3/.

Of course this does depend on the work being finished:

  1. The work in progress index has the field isPreferredName, but it is not populated correctly yet.
  2. The current index does not indicate Princess Parrot is the preferred common name, which would fix this issue. The work in progress index does not contain Alexandra's Parrot and while this would also fix the problem described, because there are no other common names for this LSID, it is clear that this is still incomplete work because the non-preferred common name was removed while still being a common name in use https://lists.ala.org.au/speciesListItem/list/dr656?q=Polytelis+alexandrae, http:https://www.environment.gov.au/cgi-bin/sprat/public/publicspecies.pl?taxon_id=758.

@adam-collins
Copy link
Contributor

There is a change in expectations. The common name that the BIE and namematching return will not be the same, just less random.

@adam-collins adam-collins self-assigned this Jan 29, 2024
@adam-collins adam-collins added this to the 3.2.0 milestone Jan 29, 2024
adam-collins added a commit that referenced this issue Apr 1, 2024
…-name

#373 align common name with namematching-service
@adam-collins
Copy link
Contributor

Now aligned with namematching service. For example bie-index returns commonNameSingle that is the same as namematching vernacularName, search result, species page, bie-index, namematching

Please test, on test

  • commonNameSingle in bie-index is the same as the vernacularName in namematching.
  • commonNameSingle is the prominent common name, where there are more than one, in ala-bie-hub.

@kylie-m
Copy link
Author

kylie-m commented May 7, 2024

Looks like it's all working ok, passing for me. @CamSlatyer and @TaniaGLaity do you have anything else to add here?

Items tested:

@Sherrin-ALA
Copy link

Looks good to me.

@TaniaGLaity
Copy link

I think it looks good to me too..

@CamSlatyer
Copy link

CamSlatyer commented May 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants