Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plotting tools #490

Merged
merged 12 commits into from
Mar 31, 2023
Merged

Fix plotting tools #490

merged 12 commits into from
Mar 31, 2023

Conversation

rs028
Copy link
Collaborator

@rs028 rs028 commented Mar 23, 2023

A little time to kill in between flights... this is meant to resolve the issues in #269.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #490 (d7a20b6) into master (739879e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files          17       17           
  Lines        2046     2046           
=======================================
  Hits         1367     1367           
  Misses        679      679           
Flag Coverage Δ
build 52.81% <ø> (ø)
tests 67.17% <ø> (ø)
unittests 54.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739879e...d7a20b6. Read the comment docs.

@rs028
Copy link
Collaborator Author

rs028 commented Mar 23, 2023

@spco, this is starting to be annoying... in PR #482, all the macos tests fail. On this PR only one test for macos12 fails (and for a different reason... the codebase is basically the same! 😡

@rs028 rs028 mentioned this pull request Mar 28, 2023
@rs028
Copy link
Collaborator Author

rs028 commented Mar 30, 2023

I will merge this, even though thte tests fails, since it only changes the plotting tools, which are independent from the rest of the code.

@rs028 rs028 merged commit 6650b8a into AtChem:master Mar 31, 2023
@rs028 rs028 deleted the fix_plotting_tools branch March 31, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant