Fixed input and output of constant photolysis rates #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 55.37% 55.40% +0.02%
==========================================
Files 17 17
Lines 2046 2045 -1
==========================================
Hits 1133 1133
+ Misses 913 912 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Are we happy to merge this? Looks all right to me. |
spco
reviewed
Feb 11, 2022
| @@ -145,7 +145,7 @@ subroutine outputPhotolysisRates( t ) | |||
| write (58, '(100A15) ') 't', (trim( constantPhotoNames(i) ), i = 1_NPI, numConstantPhotoRates) | |||
| firstTime = .false. | |||
| end if | |||
| write (58, '(100 (ES15.6E3)) ') t, (j(ck(i)), i = 1_NPI, numConstantPhotoRates) | |||
| write (58, '(100 (ES15.6E3)) ') t, (j(constantPhotoNumbers(i)), i = 1_NPI, numConstantPhotoRates) | |||
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #372.
I have also removed the ignoring of the first line in the
photolysisConstant.configfile, when read byinputFunctions.f90.Changing the
inputFunctions.f90file as discussed in #372 resulted in issues with theoutputFunctions.f90file, which I believe I have also fixed.It's worth noting that when using at least one constant J value only the constant J values are output in the
photolysisRates.outputfile. I assumed this was by design since thephotolysisConstant.configoverrides other photolysis rates and sets them to 0 (even if they are specified as constrained), e.g. giving a value of 1E-5 for J1 inphotolysisConstant.configand listing J2 inphotolysisConstrained.configwill result in a model where J1 = 1E-5 throughout and J2 = 0, regardless of what the J2 constraint file says.Hopefully this is all OK and makes sense, let me know if there's anything else that needs changing.