Catch missing RO2 species error when prepping #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an exception where an RO2 species is encountered in the RO2 sum of the mechanism file but isn't encountered in the mechanism species list. We shouldn't get to a point where there is an RO2 species in mechanism.ro2 that isn't in the full species list in the mechanism, so the user needs to correct their mechanism file before running the model!
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 65.51% 65.51%
=======================================
Files 17 17
Lines 2047 2047
=======================================
Hits 1341 1341
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
spco
reviewed
Aug 3, 2021
build/mech_converter.py
Outdated
| @@ -463,7 +463,15 @@ def convert(input_file, mech_dir, mcm_dir): | |||
| # This code only executes if the break is NOT called, i.e. if the loop runs to completion without the RO2 being | |||
| # found in the species list | |||
| else: | |||
| ro2_file.write('0 ! error RO2 not in mechanism: ' + ro2List_i + '\n') | |||
| error_message = ' ****** Warning: RO2 species "' + str(ro2List_i.strip()) + '" NOT found in the mechanism. Please check the RO2 section of your mechansm file for incorrect species names! ******' | |||
There was a problem hiding this comment.
I think this line has snuck into the commit and needs removing.
There was a problem hiding this comment.
Yep you're right - relic from messing around.
I've removed that line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an exception where an RO2 species is encountered in the RO2 sum of the mechanism file but isn't encountered in the mechanism species list.
We shouldn't get to a point where there is an RO2 species in mechanism.ro2 that isn't in the full species list in the mechanism, so I think the user needs to correct their mechanism before building and running the model, as opposed to a warning being shown and them being allowed to erroneously continue.
I had a look at adding some error handling to the
ro2Sumfunction inoutputFunctions.f90- it is apurefunction which disallowserror stop. I think there would be a bit too much unpicking to make that error handling neat, so I avoided it.Let me know what you think - happy to make changes as requested.
Closes #453