Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CVODE download URL #454

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Update CVODE download URL #454

merged 1 commit into from
Aug 2, 2021

Conversation

kilicomu
Copy link
Contributor

@kilicomu kilicomu commented Aug 2, 2021

The CVODE releases have moved to GitHub - download URL has been updated and call to wget has been modified to save the archive to the filename that matches the rest of the installation script.

@spco
Copy link
Collaborator

spco commented Aug 2, 2021

Ugh, looks like Actions images have moved on and no longer supply gfortran 8 out of the box. I can raise a PR to remove gfortran-8 from the matrix of environments, though it would be good in future to continue to run tests on 8.

@spco
Copy link
Collaborator

spco commented Aug 2, 2021

I've remove gfortran-8 from the build matrix - could you rebase and run these again please @kilicomu ?

The CVODE releases have moved to GitHub - download URL has been updated
and call to `wget` has been modified to save the archive to the filename
that matches the rest of the installation script.
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #454 (cf2b819) into master (9c06d09) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   65.51%   65.46%   -0.05%     
==========================================
  Files          17       17              
  Lines        2047     2047              
==========================================
- Hits         1341     1340       -1     
- Misses        706      707       +1     
Flag Coverage Δ
build 52.23% <100.00%> (ø)
tests 82.80% <100.00%> (-0.02%) ⬇️
unittests 31.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/atchem2.f90 87.68% <100.00%> (ø)
src/interpolationFunctions.f90 34.09% <0.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10eedfe...cf2b819. Read the comment docs.

@spco spco merged commit ad73e3b into AtChem:master Aug 2, 2021
@spco
Copy link
Collaborator

spco commented Aug 2, 2021

Ignore the codecov - it's now garbage. Thanks @kilicomu !

@kilicomu kilicomu deleted the bugfix/update_cvode_download_url branch August 2, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants