Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start dev version #430

Merged
merged 8 commits into from
Jun 11, 2020
Merged

Start dev version #430

merged 8 commits into from
Jun 11, 2020

Conversation

rs028
Copy link
Collaborator

@rs028 rs028 commented Jun 10, 2020

This starts the new development cycle and fixes a couple of minor issues.

@spco
Copy link
Collaborator

spco commented Jun 10, 2020

You'll need to repeat

read (10,*)
now that mechanism.ro2 has 2 comment lines at the top that need skipping rather than 1 previously.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #430 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files          17       17           
  Lines        2262     2262           
=======================================
  Hits         2007     2007           
  Misses        255      255           
Flag Coverage Δ
#build 62.45% <100.00%> (ø)
#tests 87.88% <100.00%> (ø)
#unittests 35.76% <100.00%> (ø)
Impacted Files Coverage Δ
src/atchem2.f90 90.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a18fca...9f9263e. Read the comment docs.

@rs028
Copy link
Collaborator Author

rs028 commented Jun 10, 2020

Easier to go back to a single line :)

But I don't understand why the tests were passing on my machine (?)

@rs028
Copy link
Collaborator Author

rs028 commented Jun 11, 2020

@spco happy for me to merge this?

@spco
Copy link
Collaborator

spco commented Jun 11, 2020

Seems so!

@rs028 rs028 merged commit 018cf02 into AtChem:master Jun 11, 2020
@rs028 rs028 deleted the start_version branch June 11, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants