Modifies respiration diag #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt
This is similar to #51.
The new respiration diags for C, N and P all use the variables "phy", "INi" and "IPi". These change with phyto group but the location of the diag writing for diags id_PhyRSPc, id_PhyRSPn and id_PhyRSPp mean that the values of phy, INi and IPi from the last phyto group were being used to compute and write these respiration diags. This meant that if simulating two phyto groups, both were recording the same respiration diag data (i.e. that of the second phyto group) because phy, INi and IPi were the values left over from the previous loop on num_phy. Mass balance calculations were affected and the diags were difficult to interpret.
This suggestion reloads the correct phyto group by phyto group values of phy, INi and IPi before calculating and recording the respiration diagnostics. I have run the revised code and this fixes the mass balance issues.
MB