Added context support #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranharel
suggested changes
May 12, 2021
…o AppsFlyer-master # Conflicts: # check_task.go # checks/custom.go # checks/dns.go # config.go # health.go # http/handler_test.go
…o AppsFlyer-master # Conflicts: # check_task.go # checks/custom.go # checks/dns.go # config.go # health.go # http/handler_test.go
sagikazarmark
suggested changes
May 17, 2021
Co-authored-by: Márk Sági-Kazár <[email protected]>
Co-authored-by: Márk Sági-Kazár <[email protected]>
Co-authored-by: Márk Sági-Kazár <[email protected]>
eranharel
suggested changes
May 20, 2021
eranharel
suggested changes
May 20, 2021
|
README still contains broken code snippets, e.g. |
eranharel
reviewed
May 25, 2021
health.go
Outdated
| @@ -38,10 +39,16 @@ func New(opts ...HealthOption) Health { | |||
| for _, opt := range append(opts, WithDefaults()) { | |||
| opt.apply(h) | |||
| } | |||
|
|
|||
| if h.ctx == nil { | |||
There was a problem hiding this comment.
Is there a case where it's not nil?
eranharel
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added context support to check.Check