Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes, improvements and Demo project #32

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Fixes, improvements and Demo project #32

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5d067d8
fixed album image not being set on launch.
denysco Feb 23, 2018
63242a3
changed contentMode from scaleAspectFit scaleAspectFill to make image…
denysco Feb 23, 2018
475b92d
Fixed retain cycled delegate in PlayerSlider
Apr 5, 2018
56b2cb4
Fixed retain cycle inside PandoraPlayer prefetchItems method
Apr 5, 2018
f64030c
CenterCellCollectionViewLayout targetColumn now computed properly
Apr 5, 2018
48f9b7f
Merge pull request #1 from denysco/master
rivera-ernesto Dec 21, 2018
35adcc3
Merge pull request #2 from Adiletkozha/Ad_fix_branch
rivera-ernesto Dec 21, 2018
a125488
Add .gitignore
rivera-ernesto Dec 21, 2018
88d8ae3
Update podspec
rivera-ernesto Dec 21, 2018
3d507f7
Update to Swift 4.2
rivera-ernesto Dec 21, 2018
76aafbc
Fix deprecation warnings
rivera-ernesto Dec 21, 2018
3ebd55d
Add static_framework to podspec to fix Target has transitive dependen…
rivera-ernesto Dec 21, 2018
ec5c3cf
Fix deprecation warnings
rivera-ernesto Jan 9, 2019
f08e1b9
Update project
rivera-ernesto Jan 9, 2019
1e85fa9
Fix Storyboard’s module
rivera-ernesto Jan 9, 2019
50fd692
Bring close button on top of title label
rivera-ernesto Jan 9, 2019
8d2bfee
Make sure to load views first on configurePlayer() to prevent unwrap …
rivera-ernesto Jan 9, 2019
043d99c
Allow initializing player with no playback items
rivera-ernesto Jan 9, 2019
b88e282
Remove never used AppIcon asset
rivera-ernesto Jan 9, 2019
da615c3
Fix Xib file
rivera-ernesto Jan 9, 2019
9f25824
Fix project SWIFT_VERSION to 4.2
rivera-ernesto Jul 2, 2020
efe7741
Add demo project
rivera-ernesto Jul 2, 2020
f4ff979
Fix build warnings
rivera-ernesto Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix project SWIFT_VERSION to 4.2
  • Loading branch information
@rivera-ernesto
rivera-ernesto committed Jul 2, 2020
commit 9f25824d86e27ad343f027e6a0832015d242ea76
5 changes: 3 additions & 2 deletions Player.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@
developmentRegion = English;
hasScannedForEncodings = 0;
knownRegions = (
English,
en,
Base,
);
Expand Down Expand Up @@ -532,7 +533,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.applikeySolutions.Player;
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
TARGETED_DEVICE_FAMILY = 1;
};
name = Debug;
Expand All @@ -553,7 +554,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.applikeySolutions.Player;
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
TARGETED_DEVICE_FAMILY = 1;
};
name = Release;
Expand Down