Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issues was made previously but a discussion was done in a coding session.
📖 Description
Here's a sneak peek of the changes:
FirebaseStorageService
.ets-mobile
. More details in wiki.QuicklinkRepository.getDefaultQuicklink(AppIntl)
icon
andremotePath
attributes are mutually exclusive which means one should be null if the other one is defined. In the case there is an error with the definition in remote config, icon will take precedence.Example of remote config data
Drawback:
The main drawback of using a map to load up icons (which allows us to get them dynamically) is that there is no tree shaking for the unused resources. We would need to analyze if the app size is still acceptable. In the case it's not, we would need to do manual cleansing of some dynamically provided key from font awesome package as read here.
🧪 How Has This Been Tested?
Added a couple of test to extract default quicklinks from remote config and from cache and a test to getImageUrl from the newly created FirebaseStorageService.
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.🖼️ Screenshots (if useful):