Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UltraStar_Deluxe #3116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create UltraStar_Deluxe #3116

wants to merge 3 commits into from

Conversation

s09bQ5
Copy link

@s09bQ5 s09bQ5 commented Mar 5, 2023

No description provided.

@probonopd
Copy link
Member

Hello @s09bQ5, do you know which tools were used to make this AppImage?

Squashfs image uses xz compression, this version supports only zlib, zstd.

This automated test supports only zlib, zstd compression. I am wondering which AppImage generation tool uses xz compression.

@s09bQ5
Copy link
Author

s09bQ5 commented Jun 18, 2023

This automated test supports only zlib, zstd compression. I am wondering which AppImage generation tool uses xz compression.

We are using appimagetool --comp xz .... to create the AppImages. The appimagetool is built from Git tag 13 of the AppImageKit repository.

@probonopd
Copy link
Member

Can you please retry with --comp zstd or without --comp? Thanks.
While the spec doesn't mandate a certain compression (yet), this automated test currently supports only zlib and zstd compression.

@s09bQ5
Copy link
Author

s09bQ5 commented Jun 18, 2023

We made a new stable release 7 hours ago. I don't think we will replace those binaries before our next release in July.

Wouldn't it make more sense to replace the runtime binary used for the test with a new one that is capable of mounting xz compressed squashfses? Why do the test use https://github.com/AppImage/appimage.github.io/releases/download/deps/runtime-fuse2-x86_64 instead of https://github.com/AppImage/AppImageKit/releases/download/13/runtime-x86_64? The latter can mount our AppImage without any problems. Does it really need to be statically linked?

@probonopd
Copy link
Member

probonopd commented Jun 18, 2023

Yes, we are transitioning to the statically linked runtime soon.

And possibly standardize on zstandard (no pun intended):

Out of curiosity, what was your rationale for choosing xz? In our tests, zstd outperformed everything else.

s09bQ5 added a commit to s09bQ5/USDX that referenced this pull request Jun 18, 2023
@s09bQ5
Copy link
Author

s09bQ5 commented Jun 19, 2023

Not even current HEAD of AppImageKit supports zstd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants