Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sunshine #2881

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Add sunshine #2881

merged 2 commits into from
Nov 2, 2022

Conversation

ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented May 6, 2022

Adds AppImage of Sunshine

@probonopd
Copy link
Member

Please don't do this:

https://github.com/SunshineStream/Sunshine/blob/4b658cd86ba0b7520f6f7cb5b5f07d6775845a81/.github/workflows/CI.yml#L117-L124

Instead, please add the files to the AppImage and copy them out of the AppImage when the application runs for the first time.

@ReenigneArcher ReenigneArcher marked this pull request as ready for review October 31, 2022 13:04
@ReenigneArcher
Copy link
Contributor Author

This is ready for review now. Thanks!

@ReenigneArcher
Copy link
Contributor Author

P.S. this image is compiled on Ubuntu 20.04 and according to appimagelint, will not run on 18.04.

The image can be compiled on 18.04, but AppImage lint fails on 18.04 (due to an issue with the tar package included in the GitHub runner).

See this unresolved issue: TheAssassin/appimagelint#28
As well as latest attempt here: https://github.com/LizardByte/Sunshine/actions/runs/3371164942/jobs/5593023238#step:8:756

GitHub is removing 18.04 runners in exactly one month though, so it will be very difficult for us to build on 18.04 even if we fix the issue with tar. https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

@probonopd
Copy link
Member

Thank you very much @ReenigneArcher

image

@probonopd probonopd merged commit 446828f into AppImage:master Nov 2, 2022
@ReenigneArcher ReenigneArcher deleted the add-sunshine branch November 2, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants