Add Benchmarks project #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
commented
Jun 7, 2021
Add basic benchmarks project for comparing the latest* NuGet version of Polly with the local project.
Extend the retry benchmarks for more usages.
Remove the Benchmarks suffix.
Add more benchmarks for different policies. Reuse the policies in the Retry benchmarks.
Remove benchmark that just hangs.
Add benchmarks for the cache policy using the implementation from Polly.Caching.MemoryCache.
Remove EventPipeProfiler as it doesn't seem to report anything that useful.
Remove another benchmark that just hangs indefinitely.
Also add a bulkhead policy to the PolicyWrap benchmarks.
Update to the latest release of BenchmarkDotNet.
Use Task.CompletedTask in .NET versions that support it.
Use TryGetValue() with dictionary, instead of ContainsKey() and the indexer.
Set LangVersion to latest now that BenchmarkDotNet supports it.
martincostello
force-pushed
the
benchmarks
branch
from
44fba25
to
030a051
Compare
|
I'm going to merge this so we have something; we can iterate on it in the future if we desire. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago I was playing around with benchmarking Polly to see if there were any allocation-related quick wins anywhere. I didn't really get anywhere with finding any, but I figured it might be worth pushing up the benchmarks project I used for it so it can be re-used in the future.