Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 Release - commit and validate public API #1632

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

martintmk
Copy link
Contributor

The issue or feature being addressed

Closes #1302

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 26, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 26, 2023
@martincostello martincostello modified the milestones: v8.0.0, v8.1.0 Sep 26, 2023
@martincostello
Copy link
Member

FYI I've created a new 8.1.0 milestone and assigned this to it.

Disable package validation for snippets and TestUtils.
Stop the `EnablePackageValidation` override for Snippets and TestUtils being overrridden.
Disable package validation for the samples.
- Remove APIs from Unshipped for Extensions.
- Add `#nullable enable` to Unshipped baselines.
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (53805c5) 84.63% compared to head (83a3189) 84.63%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1632   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <ø> (ø)
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as ready for review September 28, 2023 11:35
@martincostello martincostello enabled auto-merge (squash) September 28, 2023 11:36
@martincostello martincostello merged commit d7758d8 into main Sep 28, 2023
14 checks passed
@martincostello martincostello deleted the mtomka/post-v8-release branch September 28, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Polly V8 Release Checklist
2 participants